Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry-api, ... to 1.28.0 #272

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

📦 Updates

from 1.27.0 to 1.28.0

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.opentelemetry" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.opentelemetry" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of that -alpha is exciting.

I need to study this global some more, but I'd love to manage it as a resource instead of this nasty global reference. But that's an idiom question, not a blocker for this.

@iRevive
Copy link
Contributor

iRevive commented Jul 7, 2023

Global is tricky.

If you invoke 'GlobalOpenTelemetry.get' somewhere, and make a custom instance and also setting it as a global one via '.setResultAsGlobal' afterward, the initialization of later will fail (pretty much expected).

We can always allocate non global instance, but it depends on the interop with Java libraries

@rossabaker rossabaker merged commit fddda3d into main Jul 7, 2023
9 checks passed
@iRevive iRevive deleted the update/opentelemetry-api-1.28.0 branch July 8, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants